Add option to set HA as launcher #5348
Conversation
fpetrovski
force-pushed
the
feature/launcher
branch
from
ef632b8 to
1712549
Compare
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Fixed
Show fixed
Hide fixed
.../src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/PrefsRepositoryImpl.kt
Fixed
Show fixed
Hide fixed
.../src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/PrefsRepositoryImpl.kt
Fixed
Show fixed
Hide fixed
fpetrovski
force-pushed
the
feature/launcher
branch
2 times, most recently
from
e5411e8 to
eed5c27
Compare
|
Here's an updated video of the feature: I'm not too confident about the icons and I'm open to suggestions :) |
fpetrovski
force-pushed
the
feature/launcher
branch
2 times, most recently
from
59b0721 to
8c153fc
Compare
There was a problem hiding this comment.
Looks good I've played with it a bit. The only thing that is a bit weird is that when your back stack is empty when you press back it reloads the app. We could capture this in the WebViewActivity, but at the same time it's kinda nice when we are in launcher mode to be able to refresh the app.
I'll let @jpelgrom the final word on the PR 👍🏻
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
"Launcher" is obvious to me as someone who has used Android for a long time, but maybe not for everyone. The system settings app now seem to call it "home app", should that be mentioned somewhere or used ("launcher/home app" in the description)?
Note there is a merge conflict.
I'll let @jpelgrom the final word on the PR 👍🏻
No change in my thoughts for whether or not it fits (I think for the x% that may want behavior like this, 90% are served by app pinning). However, it now has enough safeguards that it shouldn't cause major issues, and I won't block it.
fpetrovski
force-pushed
the
feature/launcher
branch
from
8c153fc to
3601d58
Compare
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Fixed
Show fixed
Hide fixed
fpetrovski
force-pushed
the
feature/launcher
branch
from
3601d58 to
59ab41c
Compare
app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Joris Pelgröm <[email protected]>
|
Thanks @fpetrovski for your contribution 💪🏻 |
Summary
This PR is related to #5023 where it was discussed to allow HA Companion app to become a launcher.
A new option was added to the preference settings, under "Other Settings" Preference Category.
Checklist
Screenshots
Any other notes